Skip to content

Conversation

@Ian-Hodges
Copy link
Contributor

@Ian-Hodges Ian-Hodges commented Jan 19, 2026

Description

Add Print Analyser component.

Context

The print analyser component responds to file.safe events and performs the following:

  1. Fetches the pdf file from S3.
  2. Determines the page count.
  3. Calculates a hash of the pdf.
  4. Sends a print.analysed event with these details.

Test evidence

Receipt of file.safe event and routing through to sqs queue.

image

Receipt of pdf.analysed event with the page count.

image

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Ian-Hodges Ian-Hodges changed the title CCM-13768: add basic print analyser function CCM-13768 Print analyser component Jan 21, 2026
@Ian-Hodges Ian-Hodges marked this pull request as ready for review January 21, 2026 14:18
@Ian-Hodges Ian-Hodges requested review from a team as code owners January 21, 2026 14:18
@tdroza-nhs tdroza-nhs self-assigned this Jan 21, 2026
tdroza-nhs
tdroza-nhs previously approved these changes Jan 21, 2026
@Ian-Hodges Ian-Hodges force-pushed the feature/CCM-13768_print-analyser branch from d7b9fe9 to 30a7612 Compare January 22, 2026 08:28
Copy link
Contributor

@nhsd-angel-pastor nhsd-angel-pastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. I just wonder whether we want to add a bit of logging for the positive scenario to include like the messageReference or when supporting the app we should be mainly checking the logs from the event bus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants