generated from NHSDigital/nhs-notify-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
CCM-13476 Process print supplier statuses #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d8ee20 to
e241787
Compare
4783268 to
37557cc
Compare
11 tasks
tests/playwright/digital-letters-component-tests/print-status-handler.component.spec.ts
Show resolved
Hide resolved
nhsd-angel-pastor
previously approved these changes
Jan 15, 2026
Contributor
nhsd-angel-pastor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny comment in test
simonlabarere
previously approved these changes
Jan 16, 2026
6b9d9cd
simonlabarere
previously approved these changes
Jan 16, 2026
nhsd-angel-pastor
previously approved these changes
Jan 16, 2026
sidnhs
previously approved these changes
Jan 16, 2026
4fc7453
nhsd-angel-pastor
approved these changes
Jan 22, 2026
sidnhs
approved these changes
Jan 22, 2026
simonlabarere
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pickup and transform supplier-api letter status events to digital-letters print.letter.transitioned events.
Context
Currently reporting will need the status of the letters that are sent to the supplier-api. Other consumers may want to subscribe to them too.
Test evidence
Valid supplier-api status event received.
Event sent.
Event seen in the event bridge logs. Also the resulting print.letter.transitioned events.
Note that the end of the origin.subject property has been translated to the messageReference.
Invalid supplier-api status event received.
Event sent.
Event ends up in the DLQ.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.