Skip to content

fix bootstrap 5 data attribute with BS namespace #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
Feb 3, 2025
Merged

fix bootstrap 5 data attribute with BS namespace #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## [Unreleased]
+* no unreleased changes
* fix bootstrap 5 data attribute with BS namespace

## 2.4.0 / 2025-01-31
### Changed
Expand Down
8 changes: 4 additions & 4 deletions app/helpers/ndr_error/errors_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ def multiple_occurrences_badge_for(fingerprint)

text = "+ #{fingerprint.count - 1}"
opts = {
'class' => 'badge badge-info',
'data-toggle' => 'tooltip',
'data-placement' => 'right',
'title' => "Since #{fingerprint.created_at.to_formatted_s(:db)}"
'class' => 'badge badge-info',
'data-bs-toggle' => 'tooltip',
'data-bs-placement' => 'right',
'data-bs-title' => "Since #{fingerprint.created_at.to_formatted_s(:db)}"
}

content_tag(:span, text, opts)
Expand Down
4 changes: 2 additions & 2 deletions app/views/ndr_error/errors/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<%= previous_button_for(@error.previous) %>

<div class="btn-group">
<a class="btn btn-outline-secondary dropdown-toggle" data-toggle="dropdown" href="#">
<a class="btn btn-outline-secondary dropdown-toggle" data-bs-toggle="dropdown" href="#">
<%= pluralize(@error.similar_errors.length - 1, 'Similar Error') %> Stored
<span class="caret"></span>
</a>
Expand All @@ -45,7 +45,7 @@

<% if @fingerprint.caused_error_fingerprints.any? %>
<div class="btn-group">
<a class="btn btn-outline-secondary dropdown-toggle" data-toggle="dropdown" href="#">
<a class="btn btn-outline-secondary dropdown-toggle" data-bs-toggle="dropdown" href="#">
<%= pluralize(@fingerprint.caused_error_fingerprints.length, 'Downstream Error') %> Stored
<span class="caret"></span>
</a>
Expand Down
4 changes: 2 additions & 2 deletions test/unit/helpers/ndr_error/errors_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ class ErrorsHelperTest < ActionView::TestCase
print.stubs(count: 3)

actual = multiple_occurrences_badge_for(print)
expected = '<span class="badge badge-info" data-placement="right"' \
' data-toggle="tooltip" title="Since 2015-01-01">+ 2</span>'
expected = '<span class="badge badge-info" data-bs-placement="right"' \
' data-bs-toggle="tooltip" data-bs-title="Since 2015-01-01">+ 2</span>'

assert_dom_equal expected, actual
end
Expand Down
Loading