Skip to content

APPT-1893 LastUpdatedBy integration tests and custom httpClient refactor#1379

Merged
jsed-nhs merged 16 commits intomainfrom
APPT-1893/last_updated_by
Feb 2, 2026
Merged

APPT-1893 LastUpdatedBy integration tests and custom httpClient refactor#1379
jsed-nhs merged 16 commits intomainfrom
APPT-1893/last_updated_by

Conversation

@jsed-nhs
Copy link
Contributor

@jsed-nhs jsed-nhs commented Jan 30, 2026

Description

Replace All - 'Http' with 'GetHttpClientForTest' in all integration tests. This allows test setup to define their own api user with certain permissions. This helps confirm the lastUpdatedBy value updates between users. Also helps future testing flexibility.
Usage:
And I register and use a http client with details

  | User Id  | Role                         | Scope  |
  | mya_user | system:integration-test-user | global |

Add - Availability, Booking, Site, and Eula 'LastUpdatedBy' integration tests, with more to add in future if needed.

Ability to generically test any document with:
[Then("the '(.+)' document with id '(.+)' and partition '(.+)' has lastUpdatedBy '(.+)'")]

Added new Base method: FindSingleItemWithRetryAsync to help find cosmos documents written by separate processes.

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@jsed-nhs jsed-nhs force-pushed the APPT-1893/last_updated_by branch from fcdc311 to 7455e25 Compare January 30, 2026 15:50
@jsed-nhs jsed-nhs marked this pull request as ready for review February 2, 2026 13:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@jsed-nhs jsed-nhs merged commit b17d170 into main Feb 2, 2026
3 checks passed
@jsed-nhs jsed-nhs deleted the APPT-1893/last_updated_by branch February 2, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants