Skip to content

[PRMP-1409] Add Document Version History feature #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lillie-dae wants to merge 3 commits into
base: main
Choose a base branch
from

minor fix

817c8a3
Select commit
Loading
Failed to load commit list.
Open

[PRMP-1409] Add Document Version History feature #1123

minor fix
817c8a3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 4, 2026 in 55s

Quality Gate passed

Issues
30 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 59 in app/src/types/fhirR4/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vMrUgV6tXU5ORVP&open=AZye_vMrUgV6tXU5ORVP&pullRequest=1123

Check warning on line 165 in app/src/types/fhirR4/bundle.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"Bundle" is overridden by string in this union type. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNDUgV6tXU5ORVS&open=AZye_vNDUgV6tXU5ORVS&pullRequest=1123

Check warning on line 35 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "number". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVb&open=AZye_vNMUgV6tXU5ORVb&pullRequest=1123

Check warning on line 50 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVg&open=AZye_vNMUgV6tXU5ORVg&pullRequest=1123

Check warning on line 23 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVX&open=AZye_vNMUgV6tXU5ORVX&pullRequest=1123

Check warning on line 44 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVe&open=AZye_vNMUgV6tXU5ORVe&pullRequest=1123

Check warning on line 32 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "number". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVa&open=AZye_vNMUgV6tXU5ORVa&pullRequest=1123

Check warning on line 17 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVV&open=AZye_vNMUgV6tXU5ORVV&pullRequest=1123

Check warning on line 70 in app/src/types/fhirR4/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vMrUgV6tXU5ORVR&open=AZye_vMrUgV6tXU5ORVR&pullRequest=1123

Check warning on line 11 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVT&open=AZye_vNMUgV6tXU5ORVT&pullRequest=1123

Check warning on line 14 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVU&open=AZye_vNMUgV6tXU5ORVU&pullRequest=1123

Check warning on line 32 in app/src/helpers/utils/documentType.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "ContentKeys". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vIqUgV6tXU5ORVK&open=AZye_vIqUgV6tXU5ORVK&pullRequest=1123

Check warning on line 38 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "number". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVc&open=AZye_vNMUgV6tXU5ORVc&pullRequest=1123

Check warning on line 260 in app/src/components/blocks/_patientDocuments/documentView/DocumentView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this component definition out of the parent component and pass data as props. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZy6NlKQ1JiK2v3hDDr_&open=AZy6NlKQ1JiK2v3hDDr_&pullRequest=1123

Check warning on line 47 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVf&open=AZye_vNMUgV6tXU5ORVf&pullRequest=1123

Check warning on line 175 in app/src/helpers/utils/documentType.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vIqUgV6tXU5ORVL&open=AZye_vIqUgV6tXU5ORVL&pullRequest=1123

Check warning on line 61 in app/src/pages/documentVersionHistoryPage/DocumentVersionHistoryPage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNWUgV6tXU5ORVi&open=AZye_vNWUgV6tXU5ORVi&pullRequest=1123

Check warning on line 46 in app/src/types/fhirR4/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vMrUgV6tXU5ORVN&open=AZye_vMrUgV6tXU5ORVN&pullRequest=1123

Check warning on line 76 in app/src/pages/documentVersionHistoryPage/DocumentVersionHistoryPage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNWUgV6tXU5ORVj&open=AZye_vNWUgV6tXU5ORVj&pullRequest=1123

Check warning on line 20 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVW&open=AZye_vNMUgV6tXU5ORVW&pullRequest=1123

Check warning on line 26 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVY&open=AZye_vNMUgV6tXU5ORVY&pullRequest=1123

Check warning on line 30 in app/src/helpers/utils/documentType.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "ContentKeys". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vIqUgV6tXU5ORVJ&open=AZye_vIqUgV6tXU5ORVJ&pullRequest=1123

Check warning on line 53 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVh&open=AZye_vNMUgV6tXU5ORVh&pullRequest=1123

Check warning on line 41 in app/src/types/fhirR4/baseTypes.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant type alias and replace its occurrences with "string". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vNMUgV6tXU5ORVd&open=AZye_vNMUgV6tXU5ORVd&pullRequest=1123

Check warning on line 53 in app/src/types/fhirR4/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZye_vMrUgV6tXU5ORVO&open=AZye_vMrUgV6tXU5ORVO&pullRequest=1123
View more details on SonarQubeCloud