[NDR-416] No snomed code required in FHIR GET requests#1119
Open
jameslinnell wants to merge 10 commits intomainfrom
Open
[NDR-416] No snomed code required in FHIR GET requests#1119jameslinnell wants to merge 10 commits intomainfrom
jameslinnell wants to merge 10 commits intomainfrom
Conversation
ebe8a13 to
a692170
Compare
Code security issues foundView full details here. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Overview
Jira ticket: NDR-416
Description
GET requests required an ID format of <snomed_code>~<doc_ref_id> However this was only setup to allow routing within NDR from the FHIR end point. This is no longer required because we can determine this by the incoming common name on Mtls certificates.
This now set the path parameters on GET to /DocumentReference/{doc_id}
Fhir response will now have id set to {doc_id}
url will match the GET endpoint, /DocumentReference/{doc_id}
Context
FHIR compliancy and standardisation.
Checklist
Tasks for all changes:
Deploy - SandboxSANDBOX Full- Deploy feature branch to sandbox