Skip to content

VED-1005: Fix S3 replication config. #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfjarvis merged 3 commits into from
Jan 9, 2026
Merged

VED-1005: Fix S3 replication config. #1116

mfjarvis merged 3 commits into from
Jan 9, 2026

Conversation

@mfjarvis
Copy link
Contributor

@mfjarvis mfjarvis commented Jan 9, 2026

Summary

  • 🤖 Operational or Infrastructure Change

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1005

dlzhry2nhs
dlzhry2nhs previously approved these changes Jan 9, 2026
View reviewed changes
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 9, 2026 16:39 — with GitHub Actions Inactive
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 9, 2026 16:41 — with GitHub Actions Inactive
@mfjarvis mfjarvis force-pushed the VED-1005-fix-replication-config branch from 36b62fd to aa4f076 Compare January 9, 2026 16:54
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 9, 2026 16:57 — with GitHub Actions Inactive
@mfjarvis mfjarvis changed the title VED-1005: Add required metrics block to replication config. VED-1005: Fix S3 replication config. Jan 9, 2026
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 9, 2026 17:04 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mfjarvis mfjarvis enabled auto-merge (squash) January 9, 2026 17:06
@mfjarvis mfjarvis temporarily deployed to internal-dev-sandbox January 9, 2026 17:08 — with GitHub Actions Inactive
@mfjarvis mfjarvis merged commit 9243aeb into master Jan 9, 2026
19 checks passed
@mfjarvis mfjarvis deleted the VED-1005-fix-replication-config branch January 9, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlzhry2nhs dlzhry2nhs dlzhry2nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mfjarvis @dlzhry2nhs