Skip to content

Conversation

@ajmu1
Copy link
Collaborator

@ajmu1 ajmu1 commented Jan 19, 2026

Release Branch Pull Request

Description of Changes

This PR contains sonarcloud issue fixes, changing of opening times in integration tests to a future date. Also, contains fix for cloudwatch queries read-after-write consistency issue in codebuild jobs during terraform apply.

JackPlowman and others added 30 commits March 30, 2023 10:48
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-46>**

## Description of Changes

This PR allows palliative care SGSD to be updated in DoS.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-99>**

## Description of Changes

Additions to automation tests to enable the checking of database entries
when palliative care is enabled.

## Type of change

Delete not appropriate

- Test

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-511>**

## Description of Changes

This PR adds security headers for the DI Endpoint API Gateway
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-524>**

## Description of Changes

This PR adds new documentation diagrams for potential upcoming
architectures.
# Task Branch Pull Request

## Description of Changes

This PR updates the DoS Version when it refreshes the DoS Environment
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-513>**

## Description of Changes

Add Server Access Logging for the send email bucket
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-106>**

## Description of Changes

This PR validates that an SDSGID exists within the database. If it
doesn't it logs to the generic error report and alerts to the slack
channel.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-638>**

## Description of Changes

This PR encrypts objects uploaded to the S3 send email bucket.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-673>**

## Description of Changes

This PR reverts back to previous db endpoints
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-705>**

## Description of Changes

This PR fixes an issue with the S3 ACL/object ownership configuration.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-705>**

## Description of Changes

This PR removes the Server Access Logging bucket to remove the issue
with ACLs. This feature will be restored after release 12.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-705>**

## Description of Changes

This PR fixes where the send email bucket is dependant on the commented
out logging bucket.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-717>**

## Description of Changes

This PR changes the branch prefix from DSUEC to DS to ensure that the
delete environment jobs work.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-711>**

## Description of Changes

This PR fixes the perf2 environment configuration.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-128>**

## Description of Changes

This PR adds an architectural decision record to explain the decision to
remove the orchestrator to improve performance.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-719>**

## Description of Changes

This PR improves palliative care logging by updating f strings and
fixing log messages.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-744>**

## Description of Changes

This PR adds a bunch of changes to CloudWatch resources to make
monitoring and support easier.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-747>**

## Description of Changes

This PR adds a Data Item metric to show what is being updated. This is
on a per data item being updated so if postcode is updated, town,
easting, northing, latitude and longitude updates are also recorded.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-707>**

## Description of Changes

This PR adds server access logging to the send email bucket that follows
the new AWS policies.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-774>**

## Description of Changes

This PR fixes F001SXX3 integration test by making the assertion work. As
well making the comparison values correct for the assertion.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-780>**

## Description of Changes

This PR updates all files in the Application folder to meet Ruff standards.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-835>**

## Description of Changes

This PR fixes a problem with Service Update metrics using the incorrect
dimensions therefore the CloudWatch data dashboard can't read the
metrics.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-817>**

## Description of Changes

This PR migrates the Blank Opening Time report from the service matcher
to the service sync. As well as adding the service region to the report.
This PR also does some clean up of the test dentist code.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-785>**

## Description of Changes

Refactor the ChangeToDoS class to move change check and validation
functions to the `compare_data.py` module.

## Type of change

- Refactoring (non-breaking change which improves the structure of the
code)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [ ] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-839>**

## Description of Changes

This PR applies learnings and improvement to the integration and
performance test suites to allow for easier expansion and improved
performance.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-86>**

## Description of Changes

This PR refactors the pre-release pipeline into a single CodeBuild stage
that builds, deploys and integration tests releases on each push.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-851>**

## Description of Changes

This PR fixes a problem with AWS_PROFILE which stops the pipelines/jobs
from running.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-845>**

## Description of Changes

This PR adds Ruff refactoring to more service sync files. As well as
removing GitHub maintainability warnings.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-836>**

## Description of Changes

This PR adds changes so that the perf and perf2 profile works with DoS
Aurora updates.
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-692>**

## Description of Changes

This PR re-applies the profiles for the Route 53 and SG which will
connect to Aurora.

Co-authored-by: Matthew Begley <[email protected]>
ajmu1 and others added 22 commits June 16, 2025 15:15
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>**

## Description of Changes

Fixing development pipeline triggering
## Type of change

- Bug fix (Fixing development pipeline triggering post PR merge)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>**

## Description of Changes

This PR revert changes from the last PR #1069

## Type of change

- Bug fix (reverting changes from last PR #1069)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>**

## Description of Changes

Updated github PAT to fix dev pipeline trigger

## Type of change

- Bug fix (Fixing dev pipeline trigger)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3900>**

## Description of Changes

This PR is to test the development pipeline trigger after manual release
pushed from AWS CP post the org transfer

## Type of change

- Bug fix (Development pipeline trigger fix)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3730>**

## Description of Changes

Remove DSP from invalid palliative care type check, as it valid for them
to have it.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
#1084)

# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4012>**

## Description of Changes

DevOps change

## Type of change


- DevOps configurations change

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4012>**

## Description of Changes

Please include a summary of the change

## Type of change

Delete not appropriate

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Refactoring (non-breaking change which improves the structure of the
code)

## Development Checklist

- [ ] I have performed a self-review of my own code
- [ ] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [ ] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4011>**

## Description of Changes

Change to improve CI/CD pipelines

## Type of change

Delete not appropriate

- Refactoring (CI/CD pipelines enhancements)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>**

## Description of Changes

Fixing issue of breaking test cases in new tester docker image

## Type of change

- Bug fix (CI/CD pipeline related change)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>**

## Description of Changes

Fixing arch image versions for test case related AWS codebuild jobs only

## Type of change

- Bug fix (CI/CD pipeline related change to fix breaking of test cases
in new tester image)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>**

## Description of Changes

Fixing breaking test cases for new tester image in CI/CD pipeline

## Type of change

- Bug fix (CI/CD pipeline related change to fix issue with new tester
image)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-3786>**

## Description of Changes

Temporarily fixing the smoke test demo stage for amr64 type.

## Type of change

Delete not appropriate

- Bug fix (Fixing breaking test cases in CI/CD pipeline issue)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4277>**

## Description of Changes

Addressing utilities and python libraries vulnerabilities identified by
Dependabot

## Type of change

- Security vulnerability fixes in utilities and python libs identified
by dependabot

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4329>**

## Description of Changes

Temp Fixing new tester image issue in blue-green CI/CD pipeline

## Type of change

Delete not appropriate

- Bug fix (Breaking change new tester image)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4329>**

## Description of Changes

Handling new tester image issue in CI/CD pipeline

## Type of change

Delete not appropriate

- Bug fix (Breaking change new tester image)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-4278>**

## Description of Changes

Terraform vulnerability fix and version upgrade 

## Type of change

Delete not appropriate

- Bug fix (Terraform vulnerability fix and version upgrade)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-939>**

## Description of Changes

This PR includes upgrade of terraform for core and provider version. It
also includes upgrade of python version from 3.12 to 3.14

## Type of change

Delete not appropriate

- Bug fix (Dependabot recommended upgrade for terraform and python
version in the DI)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-1556>**

## Description of Changes

Fixing race condition issue of cloudwatch log queries in blue-green-link
stack.

## Type of change

Delete not appropriate

- Bug fix (Race condition issue fix for cloudwatch log queries)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-1141>**

## Description of Changes

Fixing CW queries occuring during terraform apply and moving ahead with
shared resources 10 release

## Type of change

Delete not appropriate

- Bug fix (Fixing CW queries occuring during terraform apply)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-943>**

## Description of Changes

Fixing issues reported by sonarcloud for DoS-Integration repo

## Type of change

Delete not appropriate

- Bug fix (non-breaking change which fixes sonarcloud vulnerabilities
issues)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-943>**

## Description of Changes

Fixing integration test cases by setting future opening times and sonar
cloud issues

## Type of change

Delete not appropriate

- Bug fix (integration test fixes for future opening times and sonar
issues)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request

**<https://nhsd-jira.digital.nhs.uk/browse/DS-2241>**

## Description of Changes

This change is to fix the read-after-write eventual consistency issue
occuring during terraform apply operation in AWS codebuild jobs across
CI/CD pipelines.

## Type of change

Delete not appropriate

- Bug fix (Fixing CW query consistency issue during terraform apply)

## Development Checklist

- [x] I have performed a self-review of my own code
- [x] Tests have added that prove my fix is effective or that my feature
works (Integration tests)
- [x] I have updated Dependabot to include my changes (if applicable)

## Code Reviewer Checklist

- [x] I can confirm the changes have been tested or approved by a tester
@ajmu1 ajmu1 requested a review from mabe13 January 19, 2026 10:08
@ajmu1 ajmu1 changed the base branch from develop to main January 19, 2026 10:15
@sonarqubecloud
Copy link

@ajmu1 ajmu1 merged commit 71e7faf into main Jan 19, 2026
13 checks passed
@ajmu1 ajmu1 deleted the release/31.0 branch January 19, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants