Skip to content

DS-392 Flaky Integrationtest Fix #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ManithaSrinivasa merged 3 commits into from
Feb 18, 2025
Merged

DS-392 Flaky Integrationtest Fix #1044

ManithaSrinivasa merged 3 commits into from
Feb 18, 2025

Conversation

@ManithaSrinivasa
Copy link
Contributor

@ManithaSrinivasa ManithaSrinivasa commented Feb 18, 2025 •
edited by mabe13
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-392

Description of Changes

Please include a summary of the change

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change which improves the structure of the code)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@ManithaSrinivasa ManithaSrinivasa changed the title Task/ds 392 flaky integrationtest fix DS-392 flaky integrationtest fix Feb 18, 2025
@ManithaSrinivasa ManithaSrinivasa changed the title DS-392 flaky integrationtest fix DS-392 Flaky Integrationtest Fix Feb 18, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mabe13
mabe13 reviewed Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ManithaSrinivasa ManithaSrinivasa merged commit 1e65fa9 into develop Feb 18, 2025
21 of 25 checks passed
@ManithaSrinivasa ManithaSrinivasa deleted the task/DS-392_Flaky_Integrationtest_Fix branch February 18, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabe13 mabe13 mabe13 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ManithaSrinivasa @mabe13