Release/28.0 #1043
Merged
Release/28.0 #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-66>** ## Description of Changes This PR removes the old deployment pipelines which can't be used now CICD pipelines are in place.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DI-70>** ## Description of Changes Two new steps in tests to verify staff field redaction. A new step was added instead of using generic functionality because the error message does not contain a correlation id. Staff field added to the generator for the CE. ## Type of change - Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-30>** ## Description of Changes This PR allows for identifying where Palliative Care Mismatches occur
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-48>** ## Description of Changes This PR adds a report log when palliative care is currently applied to the wrong service type.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-64>** ## Description of Changes A job which checks for offending change events in DB and removes the unwanted key.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-93>** ## Description of Changes Updates the release documentation to add missed information.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-49>** ## Description of Changes Adds a new report which shows when a pharmacy is profiled unexpectedly
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-72>** ## Description of Changes This PR fixes the codebuild stage which deletes nonprod environments after a PR is merged ensuring less effort in cleaning up environments. As well I have transitioned all DI-xxx branch name references to dsuec
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-94>** ## Description of Changes This PR migrates all demo environments to now connect to UAT2 database.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-82>** ## Description of Changes Added 4 Integration tests to verify that palliative care report log entries are working properly. ## Type of change - Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-95>** ## Description of Changes This PR updates the CloudWatch Dashboard to be more useful. Such as adding a graph, adding metrics as labels.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-96>** ## Description of Changes This PR updates the GitHub actions to make them more useable and now uses best practices.
…634) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-100>** ## Description of Changes This PR allows the UecServices key of the change event to be different to what is expected. Within reason!. To ensure DI continues to function while the initial state is set to null in Profile Manager.
# Task Branch Pull Request ## Description of Changes This PR stops the release branch from failing the branch checks
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-105>** ## Description of Changes This PR fixes the source version for removing blue/green environment to ensure the right parameters are passed to the codebuild stage.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-121>** ## Description of Changes This PR updates the terraform to use security group names to get the security group id rather than getting the security group id from the RDS connected security groups.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-120>** ## Description of Changes This PR updates pyscopg2 to psycopg3 which is now called pyscopg (lol) Also I've made minor changes to made it work.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-117>** ## Description of Changes This PR upgrades DI's AWS Lambdas to use Python 3.10 with all the benefits of it such as better error tracing and slightly improved performance.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-75>** ## Description of Changes Update the setup and configuration of the application to use Route 53 address when connection to the DoS databases ## Type of change - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-127>** ## Description of Changes Please include a summary of the change ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-109>** ## Description of Changes This PR skips the palliative care checks when Palliative Care has never been set on Profile Manager
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-125>** ## Description of Changes Pin back Bandit Version to 1.7.4
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-506>** ## Description of Changes A change to the parser caused an issue with certain steps. This change just replaces the wording so the step definition is unique. ## Type of change Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
…r Aurora (#657) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-550>** ## Description of Changes This PR updates the Security Group Names and Route53 entries to the correct values ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-577>** ## Description of Changes This PR enhances to CodeQL Vulnerability Scanning to run more security checks as well as quality checks.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-125>** ## Description of Changes This PR fixes the latest warning messages from bandit ## Type of change - Bug fix (non-breaking change which fixes an issue)
) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-129>** ## Description of Changes This PR updates to code to Log only Type 13 to Unexpected Pharmacy Profiling Report when multiple type 13s are present.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-578>** ## Description of Changes Adds 2 new integration tests for report error messages regarding service type ## Type of change - Test ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-118>** ## Description of Changes This PR migrates all pipeline stages from the old pipeline roles to the new pipelines roles ## Type of change - Refactoring (non-breaking change which improves the structure of the code)
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DSUEC-46>** ## Description of Changes This PR allows palliative care SGSD to be updated in DoS.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2154>** ## Description of Changes This PR upgrades the dynamodb and secretsmanager mocking in the lambda unit tests to work with moto 5.0.0.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2170>** ## Description of Changes This PR fixes an EventBridge Rule permission issue.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2141>** ## Description of Changes This PR reverts a change which removed logging lines. The variables have been re-logged when the NHSEntity class is initalised.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2260>** ## Description of Changes Fixes Vale set up which was broken by a version update, as well it removes libraries which shouldn't be committed.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2261>** ## Description of Changes Update Vale config to not fail in develop.
…#999) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2264>** ## Description of Changes Upgrade to use latest AWS Lambda PowerTools Logging Standards by changing extra elements to instead be key word arguments.
…loyment (#1000) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2275>** ## Description of Changes Updates the `infrastructure/stacks/development-and-deployment-tools/buildspecs/deploy-shared-resources-environment-buildspec.yml` file to include showing the blue/green version variables.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2244>** ## Description of Changes This change adds a penetration test profile call pen.mk. This profile is based of the dev.mk profile but enables the WAF.
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2400>** ## Description of Changes This fixes an issue with a python package after an update to a dependency removed a underlying function. Fixed by removing pytest-bdd package version pinning. Also included in this PR is a temp fix for the build image codebuild jobs. A 20 second sleep has been put in place to give time for the aws ecr security image scan to be ready, before it's checked. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2408>** ## Description of Changes This PR adds a temp fix to the missed build image codebuild jobs used by DI's pipelines. A 20 second sleep has been put in place to give time for the aws ecr security image scan to be ready, before it's checked. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2362>** ## Description of Changes Adds a tag on the DynamoDB table to indicate we won't be using Texas's backup solution. We covered by PiTR (Point in Time Recovery) ## Type of change - New feature (non-breaking change which adds functionality) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
…#1023) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2622>** ## Description of Changes Removes ECR vulnerability scan check from PR release codebuild job used to build and test release in an environment. Reason from removal can be found in the ticket. ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
…line (#1024) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2622>** ## Description of Changes Removes ECR vulnerability scan check from the development pipeline, missed from previous DS-2622 branch. Reason from removal can be found in the ticket. ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2622>** ## Description of Changes Removes last ECR vulnerability scan check from the development pipeline, missed from previous two DS-2622 branches. The last one only removed it from webhook based buildspec. Reason from removal can be found in the ticket. ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2941>** ## Description of Changes Please include a summary of the change ## Type of change Delete not appropriate - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Refactoring (non-breaking change which improves the structure of the code) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-1462>** ## Description of Changes This PR upgrades Python to 3.12 --------- Co-authored-by: Jack Plowman <[email protected]> Co-authored-by: Matthew Begley <[email protected]>
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2829>** ## Description of Changes Adding missing HTTP security headers --------- Co-authored-by: Sindhu <[email protected]>
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2840>** ## Description of Changes SNS Encryption weakness
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-2834>** ## Description of Changes Changed rule for port 5432 to only point to the dos-integration security group rather than any IP address. ## Type of change - Bug fix (PEN test change) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester --------- Co-authored-by: Matthew Begley <[email protected]>
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3136>** ## Description of Changes Added a new constant `DistanceSelling` to the OrganisationSubType list ## Type of change Delete not appropriate - New feature (non-breaking change which adds functionality) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester --------- Co-authored-by: ManithaSrinivasa <[email protected]>
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3268>** ## Description of Changes This PR updates the lambda image builder for pipelines to use an arm based CodeBuild job. The 86x version stopped working due to an inability to install the docker xbuild plugin. The arm builder we use for task environments has not been affect by this issue. As such it makes sense to align the non-pipeline builder with the pipeline builder and have both CodeBuild jobs use an arm based container to build arm based images. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
# Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3019>** ## Description of Changes This PR includes the upgrade of AWS Terraform provider to version 5.68.0 ## Type of change - Infrastructure upgrade change ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester Co-authored-by: ajmu1 <[email protected]>
…te (#1038) # Task Branch Pull Request **<https://nhsd-jira.digital.nhs.uk/browse/DS-3293>** ## Description of Changes Updating date to a future date for open timings integration test ## Type of change - Integration test case scenario change for open timings ## Development Checklist - [x] I have performed a self-review of my own code - [x] Tests have added that prove my fix is effective or that my feature works (Integration tests) - [x] I have updated Dependabot to include my changes (if applicable) ## Code Reviewer Checklist - [x] I can confirm the changes have been tested or approved by a tester
|
mabe13
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Branch Pull Request
Description of Changes
This release was focused around upgrading the terraform AWS provider to version 5.68.0