Skip to content

Conversation

@ajmu1
Copy link
Collaborator

@ajmu1 ajmu1 commented Jan 13, 2025

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-2844

Description of Changes

This PR creates a custom WAF rule to identify the SQL injection attacks in change event request.
Please include a summary of the change

Type of change

  • Security enhancements(Prevention of SQL injections)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

mabe13
mabe13 previously approved these changes Jan 16, 2025
Copy link
Collaborator

@mabe13 mabe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ajmu1 ajmu1 force-pushed the task/DS-2844_Missing_rule_config branch from 15d0b10 to f84a4b2 Compare January 17, 2025 10:31
nsindhu26
nsindhu26 previously approved these changes Jan 20, 2025
nsindhu26
nsindhu26 previously approved these changes Jan 20, 2025
@ajmu1 ajmu1 force-pushed the task/DS-2844_Missing_rule_config branch from 26edc41 to a3e5613 Compare January 20, 2025 16:09
@sonarqubecloud
Copy link

@ajmu1 ajmu1 merged commit ef6c2b6 into develop Jan 20, 2025
15 checks passed
@ajmu1 ajmu1 deleted the task/DS-2844_Missing_rule_config branch January 20, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants