[CDAPI-100]: Integrate CI Tests with APIM Proxy III#41
Merged
nhsd-rebecca-flynn merged 1 commit intomainfrom Mar 9, 2026
Merged
[CDAPI-100]: Integrate CI Tests with APIM Proxy III#41nhsd-rebecca-flynn merged 1 commit intomainfrom
nhsd-rebecca-flynn merged 1 commit intomainfrom
Conversation
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: /tmp/artifact
✅ No vulnerabilities found. |
f133ca4 to
bf73134
Compare
b62d8e1 to
a932d9e
Compare
6349910 to
21a66d5
Compare
neil-sproston
previously approved these changes
Feb 26, 2026
Contributor
neil-sproston
left a comment
There was a problem hiding this comment.
From a platform POV it looks sane and sensible and leave us in a perfect position ready when we re-plumb the preview-env functionality back into the man CI pipelines.
Collaborator
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
Looks good to me 👍 , just a few minor comments / questions.
eb47b93 to
3d48820
Compare
nhsd-jack-wainwright
approved these changes
Mar 6, 2026
3d48820 to
617b7c2
Compare
|
|
Deployment Complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Update the integration, contract, schema and acceptance tests ran as part of the CI process to run against the deployed APIM proxy
Summary
Dual-environment test infrastructure: Tests now run against either a local Lambda (ENV=local) or a remote APIM proxy preview environment (ENV=remote), driven by .env files and Makefile targets.
Client abstraction: Client is now a Protocol with LocalClient and RemoteClient implementations; remote requests carry APIM auth headers and have longer timeouts.
CI pipeline restructure: Acceptance tests, coverage merging, and SonarCloud analysis moved from stage-2-test.yaml into preview-env.yaml; a new reusable run-test-suite composite action reduces duplication. Integration, Contract and Schema validation tests still also run locally.
Contract/status endpoint updates: _status response changed from text/plain "OK" to application/json {"status": "pass", ...} (Proxygen standard format); pact contract updated accordingly.
Context
To allow for the CI process to run before the APIM integration has been completed, the tests are currently executed against a container running within the same process, which invokes the lambda in the same way as it would be ran within AWS. This ticket looks to alter the target of the tests to instead point at the deployed APIM proxy for the Pull Request.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.