[Scoreboard] Fix memory leak

NEZNAMY · Feb 3, 2025 · d5a0ae8 · d5a0ae8
1 parent 79e56c6
commit d5a0ae8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/shared/src/main/java/me/neznamy/tab/shared/features/scoreboard/ScoreboardImpl.java b/shared/src/main/java/me/neznamy/tab/shared/features/scoreboard/ScoreboardImpl.java
@@ -179,10 +179,14 @@ public void addPlayer(@NonNull TabPlayer p) {
     public void removePlayer(@NonNull TabPlayer p) {
         if (p.scoreboardData.activeScoreboard != this) return; // not registered
         p.getScoreboard().unregisterObjective(ScoreboardManagerImpl.OBJECTIVE_NAME);
-        for (Line line : lines) {
-            if (((ScoreboardLine)line).isShownTo(p))
-                p.getScoreboard().unregisterTeam(((ScoreboardLine)line).getTeamName());
+        for (Line l : lines) {
+            ScoreboardLine line = (ScoreboardLine) l;
+            if (line.isShownTo(p)) {
+                p.getScoreboard().unregisterTeam(line.getTeamName());
+                line.removePlayerSilently(p);
+            }
         }
+        players.remove(p);
         p.scoreboardData.activeScoreboard = null;
         p.scoreboardData.titleProperty = null;
         p.scoreboardData.lineProperties.clear();