PyOpenSci review updates including optimizing and consolidating conver_byte_size, cleanup with black for flake8 warnings #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been optimising a lot of Python code recently and offer this as a potential alternative to convert_byte_size(). Removing the nested if.. elif... statements and making it easier to add additional si prefixes in the future if desired.
… instead of 1000, consolidate repeated code in aop_download.py and metadata_helpers.py
I've been optimising a lot of Python code recently and offer this as a potential alternative to convert_byte_size(). Removing the nested if.. elif... statements and making it easier to add additional si prefixes in the future if desired.
… instead of 1000, consolidate repeated code in aop_download.py and metadata_helpers.py
…s-python into bh_pos pulling latest from upstream, was not up to date with main branch
…only tests convert_byte_size
…ch matches the data portal
flake8 config file set to ignore long lines, line break before/after binary operators, and import warnings in init files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following from the PyOpenSci review: