Add support for moving folder #788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for moving folders within the folder hierarchy by introducing a new parentId field to the UpdatedFolderDTO API model. This allows users to update a folder's parent, enabling folder relocation functionality.
Key Changes:
- Added
parentIdfield toUpdatedFolderDTOusing theUpdateOrDeletetype to support setting, deleting, or leaving the parent unchanged - Updated
FolderConverterService.mergeFolderto handle parent ID changes with proper validation - Updated all test cases to include the new required
parentIdparameter
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| myndla-api/src/main/scala/no/ndla/myndlaapi/model/api/FolderDTO.scala | Added parentId field to UpdatedFolderDTO API model |
| myndla-api/src/main/scala/no/ndla/myndlaapi/service/FolderConverterService.scala | Implemented parent ID update logic with validation in mergeFolder method |
| myndla-api/src/test/scala/no/ndla/myndlaapi/service/FolderConverterServiceTest.scala | Added test cases for moving folders to new parents and removing parents |
| myndla-api/src/test/scala/no/ndla/myndlaapi/service/FolderWriteServiceTest.scala | Updated existing test cases to include the new parentId parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
myndla-api/src/main/scala/no/ndla/myndlaapi/service/FolderConverterService.scala
Show resolved
Hide resolved
myndla-api/src/test/scala/no/ndla/myndlaapi/service/FolderConverterServiceTest.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Burde ikke rank oppdateres ved flytting? |
Member
Author
Godt poeng! Ser på det. |
jnatten
reviewed
Oct 21, 2025
myndla-api/src/main/scala/no/ndla/myndlaapi/service/FolderConverterService.scala
Show resolved
Hide resolved
gunnarvelle
force-pushed
the
move-folder
branch
from
8ad2846 to
9f8519b
Compare
gunnarvelle
commented
Oct 23, 2025
myndla-api/src/test/scala/no/ndla/myndlaapi/service/FolderWriteServiceTest.scala
Show resolved
Hide resolved
gunnarvelle
force-pushed
the
move-folder
branch
from
0437e26 to
eadb511
Compare
gunnarvelle
commented
Oct 30, 2025
| } | ||
| } | ||
| val rank = if (parentId != existing.parentId) { | ||
| 0 |
Member
Author
There was a problem hiding this comment.
Setter rank til 0 ved flytting som fører til at ny plassering er først i ny mappe. Diskuter!
gunnarvelle
force-pushed
the
move-folder
branch
from
0a1be1b to
9602a08
Compare
gunnarvelle
force-pushed
the
move-folder
branch
from
9602a08 to
1e49b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Såg noen kommentere at dette hadde vore kjekt, og så var det greit å få til.