Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size function to index mappings #250

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Add size function to index mappings #250

merged 2 commits into from
Feb 13, 2025

Conversation

mattldawson
Copy link
Collaborator

Adds a function that returns the number of elements in an index mappings object.

@mattldawson mattldawson added the enhancement New feature or request label Feb 13, 2025
boulderdaze
boulderdaze requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a couple minor questions.

include/musica/util.hpp Outdated Show resolved Hide resolved
fortran/util.F90 Outdated Show resolved Hide resolved
@mattldawson mattldawson merged commit b443670 into main Feb 13, 2025
63 checks passed
@mattldawson mattldawson deleted the develop-add-mappings-size branch February 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores approved these changes

@boulderdaze boulderdaze boulderdaze approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattldawson @K20shores @boulderdaze