-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of GETKF/LETKF ensemble DA capability. #338
base: develop
Are you sure you want to change the base?
Conversation
2. Use LETKF/GETKF own inflation 3. add DiagEnKFOMA for HofX of ensemble analysis
due to output of log info.)
Hi @mos3r3n, I thought a bit more about your changes for the static BC for EnKF and I was wondering if in order to make it a somewhat more generic we could add a variable that indicates if bias correction is Also, now that we have a folder named |
I did the modification to directly set the bias coefficient files in the yaml, not linking them to dbOut or dbIn. That would be much cleaner. For the potential variational DA that doesn't update bias coefficient files, I prefer to leave it to the future. I will not rename 'bias' to 'biasVariational' in this PR unless you all think it is necessary. Thanks! |
Sounds good, thanks for considering these changes! |
The calculation of HofXs of ensemble analyses needs to modify dbOut to dbAna. When the bias coefficient files are set in the yaml, their locations will be changed to dbAna, too, and diagOMA will fail. I have modified it to store the HofXs of analyses in dbOut but with different suffixes, so dbAna is no longer needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments @mos3r3n!
Description
This PR introduces various new features in LETKF/GETKF:
Note: The two-step strategy is still used, due to the poor efficiency of using 'Halo' distribution for ensemble HofX calculation; EnKFDiagOMA is now still a part of ensemble DA, making it a dependency for ensemble forecasts (To be improved).
Issue closed
Closes #(if applicable)
Tests completed
Tier 1:
Tier 2 (optional):