FetchTimeseries: date-range card, CQL2 range filter, one event out - #493
Open
BhattaraiSijan wants to merge 5 commits into
Open
BhattaraiSijan wants to merge 5 commits into
BhattaraiSijan wants to merge 5 commits into
Conversation
BhattaraiSijan
marked this pull request as draft
September 24, 2026 19:38
…mits only seriesReady
BhattaraiSijan
force-pushed
the
feat/fetch-timeseries-range
branch
from
September 24, 2026 20:19
3f80146 to
2b04412
Compare
BhattaraiSijan
marked this pull request as ready for review
September 24, 2026 20:42
slesaad
added this pull request to stack #295
September 25, 2026 21:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchTimeseries gets a card: Start and End dates, over the fetch it already does. Stacked on #294; merge that first.
Why. The viewer needs to choose the period a station's series covers, and the fetcher was a no-UI tool that could only fetch whatever the URL returned.
What changes
xKey, defaultdatetime), inclusive of both days:filter=datetime >= '2018-01-01T00:00:00' AND datetime <= '2019-12-31T23:59:59'&filter-lang=cql2-text. The standarddatetime=start/endparameter is not used: every collection on the dev features API stores its date columns as text and refuses it ("Must have timestamp typed column"), while the string comparison works on all of them. Verified against the AQS collection: 8 of 24 rows for 2018–2019.seriesReady(andseriesClearedon teardown). SeriesChart is untouched and keeps accepting all four events, so any other fetcher still works.Place FetchTimeseries in the same panel as SeriesChart, listed just before it, so the card sits above the chart. Tool metadata gains an icon and a width, which the runtime reads from the mission config's tool entry.
Testing
tests/unit/fetchTimeseries.spec.jsgainswithDateRangecases (clause, encoding,?vs&, custom time key without theproperties.prefix).tests/unit/fetchTimeseriesTool.spec.jsis rewritten around the card: the fetch event shows the tool and fetches with the past-year filter; time-enabled missions seed from the time window; the filter uses the configured time property; a date change refetches and emits again; reversed dates clamp; a change before any pick fetches nothing; HTTP error, bad template and timeout show on the card and emit nothing; abort on supersede; destroy clears. Full unit suite and TypeScript check green.Manual, on the Air4US mission: click a station, press Timeseries; the card appears with the dates, the chart under it; set 2018-01-01 to 2019-12-31 and the network tab shows the
filter=clause while the chart redraws with two points per parameter.🤖 Generated with Claude Code