Skip to content

fix issue #158 invalid chunk size #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix issue #158 invalid chunk size #216

wants to merge 1 commit into from

Conversation

jessecooper
Copy link

@jessecooper jessecooper commented Oct 27, 2021 •
edited
Loading

fix issue #158 invalid chunk size

  • add logger to runner
  • handle chunk with 0 return
  • add general exception to chunk processing block to protect daemon loop (up for discussion around this for a cleaner approach)

WIP add to contributors
(https://github.com/mycroftAI/contributors)

fix issue MycroftAI#158:
df9bb85 
* add logger to runner
* handle chunk with 0 return
* add general exception to chunk processing block to protect daemon loop
@krisgesling krisgesling added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
No open projects
PR Processing
Status: Medium priority
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessecooper @krisgesling