Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeem cashu token #885

Closed
wants to merge 1 commit into from
Closed

Conversation

elnosh
Copy link
Contributor

@elnosh elnosh commented Feb 15, 2024

Still a WIP but putting it out there for feedback. This PR is to add page to redeem Cashu token.

It depends on:

So right now it does not work as is. I'm building both changes mentioned above locally and pointing to them in package.json file.

Couple things still need work/fixing:

  • CORS error when calling mint.
  • After pressing Redeem button, UI is not responsive because of CORS error. It does however add it to the wallet balance if the mint pays the invoice.
  • I was trying cashu tokens generated from different wallets and was getting some errors when parsing some of them (I think this may need changes in Waila)

@benthecarman
Copy link
Collaborator

CORS error when calling mint.

what mint are you using? might need to reach out to who is running it to add the headers

@elnosh
Copy link
Contributor Author

elnosh commented Feb 15, 2024

CORS error when calling mint.

what mint are you using? might need to reach out to who is running it to add the headers

I was testing with the moksha instance running on mutinynet -> https://moksha-mutinynet.up.railway.app

@benthecarman
Copy link
Collaborator

I reached out to him on twitter, hopefully get a response

@elnosh
Copy link
Contributor Author

elnosh commented Feb 15, 2024

ngutech21/moksha#234 in Moksha that would probably fix issues with parsing tokens from certain wallets

@ngutech21
Copy link

https://moksha-mutinynet.up.railway.app

The mint is already setting CORS-headers. You can check using curl:

 curl -v GET https://mint.mutinynet.moksha.cash/v1/info
 GET /v1/info HTTP/2
> Host: mint.mutinynet.moksha.cash
> User-Agent: curl/8.4.0
> Accept: */*
> 
< HTTP/2 200 
< content-type: application/json
< content-length: 717
< access-control-allow-origin: *
< vary: origin, access-control-request-method, access-control-request-headers
< date: Fri, 16 Feb 2024 14:57:34 GMT
< server: railway
< 
* Connection #1 to host mint.mutinynet.moksha.cash left intact
....

What is the specific error you are getting?

@futurepaul futurepaul mentioned this pull request Apr 11, 2024
@futurepaul
Copy link
Collaborator

thank you! used the logic in #1038 and made you a co-author

@futurepaul futurepaul closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants