-
Notifications
You must be signed in to change notification settings - Fork 773
fix(agent-core/mcp): sanitize recursive MCP JSON Schemas for Moonshot validator compatibility #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
519a531
fix(agent-core): prevent stack overflow on circular schema refs in sa…
7ba1449
feat(agent-core): add compatibility mapping for standard disabled and…
6f20830
fix(agent-core): integrate sanitizeMcpSchema into connectAndDiscoverT…
6dc734f
docs: add changeset for circular mcp schema and config compatibility …
8384b5c
fix(agent-core): resolve root self-recursive references (#) safely in…
c5ca92b
feat: add webdesign wp plugin files directly
7c20417
Merge remote-tracking branch 'origin/main' into debian1branch
openhands-agent 6a2f70e
Merge remote-tracking branch 'origin/main' into debian1branch
openhands-agent 9b79ee8
Merge branch 'main' into debian1branch
creatiVision 573c74c
fix(agent-core/mcp): support array items in schemas for Moonshot vali…
openhands-agent d983b7d
merge: merge origin/main into debian1branch to resolve conflicts
openhands-agent e23a98f
chore(debian1): stabilize tests and relax node engine constraints for…
openhands-agent 424d2b5
Merge branch 'debian1branch'
openhands-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@moonshot-ai/agent-core": patch | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Prevent Maximum call stack size exceeded crash on circular/recursive MCP schemas and add compatibility mappings for standard "disabled", "max_tokens", and "max_output_tokens" settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| auto-install-peers=true | ||
| engine-strict=true | ||
| engine-strict=false | ||
| strict-peer-dependencies=false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| export * from './connection-manager'; | ||
| export * from './oauth'; | ||
| export * from './schema-sanitize'; | ||
| export * from './session-config'; | ||
| export * from './tool-naming'; | ||
| export * from './types'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a developer runs
pnpm installwith Node older than 24.15.0, this setting now permits installation even thoughpackage.jsonand.nvmrcstill require 24.15.0, deferring failures to later scripts that may rely on unsupported runtime behavior. The repository explicitly requires installs to fail on an unsatisfied Node engine, so this must remain enabled unless all version declarations and runtime requirements are intentionally lowered together.AGENTS.md reference: AGENTS.md:L30-L33
Useful? React with 👍 / 👎.