feat(tui): support mouse text selection in prompt editor#2202
Open
FeiZhuLulu wants to merge 2 commits into
Open
feat(tui): support mouse text selection in prompt editor#2202FeiZhuLulu wants to merge 2 commits into
FeiZhuLulu wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4ff4f1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac60db7e61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Related to #1174
Problem
The prompt editor currently relies on keyboard navigation for cursor placement and text editing. Editing longer multi-line prompts is slow, while enabling terminal mouse reporting can interfere with native terminal selection unless the feature is explicitly gated and restores terminal state reliably.
What changed
Add experimental mouse text selection to the main prompt editor, enabled with
KIMI_CODE_EXPERIMENTAL_TERMINAL_MOUSE_INPUT=1.The editor now supports click-to-position, forward and reverse drag selection, wrapped and multi-line ranges, grapheme-safe deletion and replacement, atomic undo, and selected-text retrieval.
Ctrl+Ccopies an active selection while preserving the existing cancel/exit behavior when no selection exists.Kimi Code handles SGR mouse input only while the main editor is mounted, coalesces high-frequency drag events, maps coordinates from the latest rendered layout and actual viewport, and disables mouse reporting around dialogs, external editing, reloads, normal exit, and emergency terminal restoration. Holding
Shiftkeeps terminal-native selection and scrollback behavior available.English and Chinese documentation, package changesets, and regression coverage are included.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill is not present in this checkout.Verification
pnpm --filter @moonshot-ai/pi-tui typecheckpnpm --filter @moonshot-ai/pi-tui exec node --test test/editor.test.ts test/tui-render.test.ts— 254 passedpnpm --filter @moonshot-ai/kimi-code typecheckpnpm --filter @moonshot-ai/kimi-code exec vitest run test/tui/editor-mouse.test.ts test/tui/components/editor/custom-editor.test.ts test/tui/controllers/editor-keyboard.test.ts test/tui/commands/reload.test.ts test/tui/kimi-tui-startup.test.ts test/utils/terminal-restore.test.ts— 131 passedpnpm exec vitest run packages/node-sdk/test/config.test.ts— 12 passedpnpm --filter @moonshot-ai/pi-tui buildpnpm --filter @moonshot-ai/kimi-code buildpnpm exec changeset status --since=origin/maingit diff origin/main...HEAD --checkCtrl+C, lifecycle restoration, and coordinate stability after prompt shrinkage.