Skip to content

feat(acp-adapter): implement session/close and logout stable methods - #1728

Open
xy200303 wants to merge 5 commits into
MoonshotAI:mainfrom
xy200303:fix/acp-stable-methods
Open

feat(acp-adapter): implement session/close and logout stable methods#1728
xy200303 wants to merge 5 commits into
MoonshotAI:mainfrom
xy200303:fix/acp-stable-methods

Conversation

@xy200303

Copy link
Copy Markdown

Problem

The ACP adapter advertised a stable agent-side surface that was missing session/close and logout, leaving ACP clients unable to close sessions or sign out through the protocol.

What changed

  • Implement session/close in AcpServer: look up the session, call Session.close(), and remove it from the in-memory map. Unknown session IDs return invalid_params.
  • Implement logout in AcpServer: delegate to KimiHarness.auth.logout().
  • Advertise sessionCapabilities.close and auth.logout in initialize.
  • Add unit tests for both methods and update the capability assertion in server.test.ts.
  • Update the ACP method coverage matrix in both English and Chinese docs.
  • Add a changeset for @moonshot-ai/kimi-code.

Checklist

  • I have read the CONTRIBUTING document.
  • I have explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@changeset-bot

changeset-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 56354d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@moonshot-ai/kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6da7c6d3f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/acp-adapter/src/server.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant