Skip to content

feat: support building using busybox (alpine linux) #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jbergstroem
Copy link

@jbergstroem jbergstroem commented Mar 8, 2025

In systems that rely on busybox install -C is not available. This commit switches it for cp with the potential downside of not setting (changing) permissions. I doubt it will have an impact.

In systems that use busybox, `install -C` is not available. Switch
for `cp` instead. The potential downside is not setting (changing)
permissions. I doubt it will have an impact.
@jbergstroem jbergstroem changed the title feat: support building on alpine linux feat: support building using busybox (alpine linux) Mar 8, 2025
@dpxcc
Copy link
Contributor

dpxcc commented Mar 10, 2025

We use install -C instead of cp because it only copies the file if the content has changed
This is especially useful for incremental debug builds, as the libraries are quite large: libdelta.a (1.1G) and libduckdb.so (711M)

@dpxcc
Copy link
Contributor

dpxcc commented Mar 10, 2025

How about 569ff9a?
It uses install -C for debug builds, but install for release builds
Or we can make it depend on whether the system supports install -C or not

INSTALL_FLAGS := $(shell if install -C /dev/null /dev/null 2>/dev/null; then echo "-C"; else echo ""; fi)

@jbergstroem
Copy link
Author

Makes sense, let me merge that in and give it a go.

@dpxcc
Copy link
Contributor

dpxcc commented Jun 5, 2025

This PR is out-dated after the v0.2 re-architecture

@dpxcc dpxcc closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants