Skip to content

Conversation

gchappel
Copy link

@gchappel gchappel commented Sep 2, 2025

Description

Restores correct behaviour of returning 100 (by default) GitHub Actions runners per page via the GitHub API

Fixes: #238

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

I have run my company's internal workflow against our org with 44 total runners. With the 1.24.1 tag that we were using previously, the workflow fails because I'm trying to operate on the runners which fall between 31-44 alphabetically and this role sees them as new runners and tries to register them. With this proposed fix, the workflow succeeds because all 44 runners are returned by the API, and all runners are skipped.

note: this only pushes out the problem to 100 runners from the default of 30, the original issue in #197 mentions pagination via the link attribute in the response - I did not see this being returned from the API so I don't see how pagination could be automated.

I did not test explicitly with master or the latest tag for this role, as I couldn't see any differences in handling the per_page param between them and since this is not the actual problem I'm trying to fix (just a side quest that I hit while I was trying to fix a different work issue) I didn't want to bring in too many other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: reopen fail to identify runners when count >30
1 participant