proposed fix for #238 #239
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores correct behaviour of returning 100 (by default) GitHub Actions runners per page via the GitHub API
Fixes: #238
Type of change
How Has This Been Tested?
I have run my company's internal workflow against our org with 44 total runners. With the
1.24.1
tag that we were using previously, the workflow fails because I'm trying to operate on the runners which fall between 31-44 alphabetically and this role sees them as new runners and tries to register them. With this proposed fix, the workflow succeeds because all 44 runners are returned by the API, and all runners are skipped.note: this only pushes out the problem to 100 runners from the default of 30, the original issue in #197 mentions pagination via the
link
attribute in the response - I did not see this being returned from the API so I don't see how pagination could be automated.I did not test explicitly with
master
or the latest tag for this role, as I couldn't see any differences in handling theper_page
param between them and since this is not the actual problem I'm trying to fix (just a side quest that I hit while I was trying to fix a different work issue) I didn't want to bring in too many other changes.