Fix dynamic embedded document updates #2882
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow setting new fields that did not previouly exist on dynamic embedded documents, the
lookup_member
functions onEmbeddedDocumentField
andGenericEmbeddedDocumentField
return dynamic fields as appropriate. Special awareness is given to positional operators - see the new test cases for examples of where this is important.Here's an example of what this now allows
Resolves #2486