-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding iSIM as a trackable value during training #192
Changes from all commits
2cc3b5b
c439960
5e05b5f
5a9d434
c3faad8
90e0425
e09ce70
39d0049
1990e2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -219,7 +219,7 @@ def run_staged_learning( | |
) | ||
|
||
parameters = config.parameters | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, set up your IDE or editor to not add spurious whitespace. This distracts from actual code review. Thanks. |
||
# NOTE: The model files are a dictionary with model attributes from | ||
# Reinvent and a set of tensors, each with an attribute for the | ||
# device (CPU or GPU) and if gradients are required | ||
|
@@ -301,7 +301,7 @@ def run_staged_learning( | |
distance_threshold = parameters.distance_threshold | ||
|
||
model_learning = getattr(RL, f"{model_type}Learning") | ||
|
||
if callable(write_config): | ||
write_config(config.model_dump()) | ||
|
||
|
@@ -329,7 +329,7 @@ def run_staged_learning( | |
else: | ||
state = ModelState(agent, package.diversity_filter) | ||
logger.debug(f"Using stage DF") | ||
|
||
optimize = model_learning( | ||
max_steps=package.max_steps, | ||
stage_no=stage_no, | ||
|
@@ -344,6 +344,7 @@ def run_staged_learning( | |
inception=inception, | ||
responder_config=responder_config, | ||
tb_logdir=logdir, | ||
tb_isim=parameters.tb_isim, | ||
) | ||
|
||
if device.type == "cuda" and torch.cuda.is_available(): | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ class ReinventConfig(GlobalConfig): | |
use_cuda: Optional[bool] = Field(True, deprecated="use 'device' instead") | ||
tb_logdir: Optional[str] = None | ||
json_out_config: Optional[str] = None | ||
tb_isim: Optional[bool] = False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not needed as global parameter because it is only relevant in the RL parameter section. |
||
seed: Optional[int] = None | ||
parameters: dict | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but we would also need to update the requirements file and the pyproject.toml file