Upgrade node-core-library and prettier, task updates in core-build-tasks #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachcampbellskyboxlabs
requested review from
rlandav and
JakeShirley
as code owners
rlandav
reviewed
Apr 18, 2025
There was a problem hiding this comment.
Important to file an issue on the just.js repo, and we could consider making a contribution there as well (i've done that in the past). The other thing is please audit if any other dependencies need major updates, because I think this would really be a major breaking change for core-build-tasks
change/@minecraft-core-build-tasks-202c9a20-f293-479e-b78c-61c363fcdbcc.json
Outdated
Show resolved
Hide resolved
…ons to vitestTask
zachcampbellskyboxlabs
changed the title
rlandav
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align dependency versions across projects:
Task updates:
prettierTaskincoreLint.just-scriptshas a hard dependency on prettier v2, because prettier v3 changes the name of bin-prettier.js which just-scripts looks for: https://github.com/microsoft/just/blob/main/packages/just-scripts/src/tasks/prettierTask.ts#L46vitestTaskto allow specifying test patterns and to allow snapshot updatingnpxwhen executing tasks (vitest, prettier, eslint)