Skip to content

Conversation

jonc125
Copy link
Contributor

@jonc125 jonc125 commented Nov 10, 2020

No description provided.

Plotting old and new traces look identical, and the numerical errors are small, so I reckon these are all fine.
These cases now run to completion, so storing results for posterity.
@jonc125 jonc125 self-assigned this Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #227 (37e8d52) into master (06e616f) will decrease coverage by 0.07%.
The diff coverage is 44.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   87.95%   87.88%   -0.08%     
==========================================
  Files          26       26              
  Lines        5041     5059      +18     
  Branches     1005     1007       +2     
==========================================
+ Hits         4434     4446      +12     
- Misses        441      449       +8     
+ Partials      166      164       -2     
Impacted Files Coverage Δ
fc/cli.py 0.00% <0.00%> (ø)
fc/data_loading.py 39.39% <0.00%> (-7.04%) ⬇️
fc/code_generation.py 97.68% <100.00%> (+0.14%) ⬆️
fc/simulations/model.py 88.77% <100.00%> (ø)
fc/protocol.py 91.20% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e616f...37e8d52. Read the comment docs.

@jonc125 jonc125 mentioned this pull request Nov 10, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant