Add StoreKit Configuration support to Xcode Schemes. #3185
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,26 @@ | ||||||||
| import Foundation | ||||||||
| extension URL { | ||||||||
| func relativize(from source: URL) -> String { | ||||||||
|
There was a problem hiding this comment. We haven’t needed this until now. I question if we still need it. Is there a way to make sure it comes in correctly from Starlark instead? There was a problem hiding this comment. I struggled with this a lot. I suppose I could relativize this within starlark and provide a relative path there, but there is no great way to get a true path to the file via the rule itself. The schemes are encoded via json and supplied here: https://github.com/MobileNativeFoundation/rules_xcodeproj/blob/main/xcodeproj/internal/xcodeproj_incremental_rule.bzl#L835 And other things within the scheme match up based on identifier encodings, but this requires a path that is relative to the resultant scheme directory itself in the generated xcodeproj from what I can tell. I am happy to do it differently, but I think the outcome ends up being something considerably more complex. I'm not particularly experienced in working with rules_xcodeproj, so after banging my head on this for a little bit I threw up my hands and went with this. Open to suggestions! There was a problem hiding this comment. Mainly we want to be able to "cache" things in Bazel. Doing this work in the generator means it's re-done every time the generator runs. I'll leave it up to the other @MobileNativeFoundation/rules_xcodeproj-maintainers on what they think about this. |
||||||||
| let sourceComponents = source.deletingLastPathComponent().pathComponents | ||||||||
| let destComponents = self.pathComponents | ||||||||
|
|
||||||||
| // Find common prefix | ||||||||
| var commonPrefixCount = 0 | ||||||||
| while commonPrefixCount < sourceComponents.count && | ||||||||
| commonPrefixCount < destComponents.count && | ||||||||
| sourceComponents[commonPrefixCount] == destComponents[commonPrefixCount] { | ||||||||
| commonPrefixCount += 1 | ||||||||
| } | ||||||||
|
|
||||||||
| // Build relative path | ||||||||
| var result = [String]() | ||||||||
|
|
||||||||
| // Add "../" for each level to go up | ||||||||
| result.append(contentsOf: Array(repeating: "..", count: sourceComponents.count - commonPrefixCount)) | ||||||||
|
|
||||||||
| // Add remaining destination components | ||||||||
| result.append(contentsOf: destComponents[commonPrefixCount...]) | ||||||||
|
|
||||||||
| return result.joined(separator: "/") | ||||||||
| } | ||||||||
| } | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this alphabetical.