Fix an rsync issue causing "Permission denied" errors #3176
Conversation
thiagohmcruz
force-pushed
the
thiago/workaround-rsync-perm-denied-errors
branch
from
4df68bc to
b06bcfe
Compare
| @@ -63,6 +63,9 @@ if [[ -n "${BAZEL_OUTPUTS_DSYM:-}" ]]; then | |||
| $(xargs -n1 <<< "$BAZEL_OUTPUTS_DSYM") \ | |||
| "$TARGET_BUILD_DIR" | |||
|
|
|||
| # Works around an rsync issue causing "Permission denied" errors | |||
| chmod +w "$TARGET_BUILD_DIR" | |||
There was a problem hiding this comment.
Do we want to do this unconditionally or per OS version? Lacking some context about the previous PR adding --perms so wanted to confirm
There was a problem hiding this comment.
cc @luispadron @brentleyjones when you're available I'd appreciate if you could clarify please 🙇
There was a problem hiding this comment.
I don't think we want a version check.
Signed-off-by: Thiago Cruz <[email protected]>
thiagohmcruz
force-pushed
the
thiago/workaround-rsync-perm-denied-errors
branch
from
b06bcfe to
7f854f4
Compare
thiagohmcruz
changed the title
|
for some reason i'm still facing |
@iMostfa are you able to provide a repro for this? Maybe a small zipped project or using of the examples in |
|
@thiagohmcruz is there anything else i can do to help you debug the issue ? |
@iMostfa there's an ongoing discussion in the Bazel slack, some folks finding issues in their internal setup as well, maybe check that thread and see if it helps? I'm holding this PR for now as I'm not sure if it's fully addressing the issue. I'll have to run more tests to verify that, thx for the help so far! |
|
It seems like there's a fix in the works, closing this for now. |
|
I don't think the homebrew path is a long term fix. It would be nice to have a different reliable route if possible. |
Follow up to #3175