Create xcodeproj_extra_files aspect hint #3150
Conversation
xcodeproj/defs.bzl
Outdated
| @@ -34,6 +35,7 @@ project_options = _project_options | |||
| top_level_target = _top_level_target | |||
| top_level_targets = _top_level_targets | |||
| xcodeproj = _xcodeproj | |||
| xcodeproj_extra_files = _xcodeproj_extra_files | |||
There was a problem hiding this comment.
We are moving away from a single file for loads, so let’s instead just have the aspect hint live one level up.
There was a problem hiding this comment.
Can you help me understand how I should structure the dependencies if I move the aspect hit up a level?
I need xcodeproj/internal/files/incremental_input_files.bzl to depend on the new aspect hit which I currently have defined in xcodeproj/xcodeproj_extra_files.bzl which I think is were you're suggesting I put it in this comment.
This results in xcodeproj_extra_files.bzl being included in the sources glob for the//xcodeproj:xcodeproj bzl_library, but since the xcodeproj library depends on //xcodeproj/internal I don't know how to resolve the dependency for xcodeproj/internal/files/incremental_input_files.bzl.
There was a problem hiding this comment.
I moved things back to the way I could get the dependency tree working. Let me know if there's a better way to structure this.
test/internal/xcodeproj_extra_files/xcodeproj_extra_files_tests.bzl
Outdated
Show resolved
Hide resolved
jflan-dd
changed the title
jflan-dd
force-pushed
the
jflan/extra-files-aspect
branch
from
8e212cc to
aea12b7
Compare
Signed-off-by: John Flanagan <[email protected]>
jflan-dd
force-pushed
the
jflan/extra-files-aspect
branch
from
aea12b7 to
742d3f6
Compare
Create an aspect hint to allow dependencies to propagate up extra files that should be include in the Xcode navigator