Use --perms with rsync (#3175)

This should fix writable permissions issues on all versions of macOS
that we support.

Signed-off-by: Brentley Jones <[email protected]>

Author: brentleyjones

xcodeproj/internal/bazel_integration_files/copy_dsyms.sh

@@ -49,14 +49,6 @@ EOF
 if [[ -n "${BAZEL_OUTPUTS_DSYM:-}" ]]; then
   cd "${BAZEL_OUT%/*}"
 
-  if [[ "$(sw_vers -productVersion)" == "15.4.0" ]]; then
-    # 15.4.0's `rsync` has a bug that requires the src to have write
-    # permissions. We normally shouldn't do this as it modifies the bazel output
-    # base, so we limit this to only macOS 15.4.0.
-    # shellcheck disable=SC2046
-    chmod -R +w $(xargs -n1 <<< "$BAZEL_OUTPUTS_DSYM")
-  fi
-
   # shellcheck disable=SC2046
   rsync \
     --copy-links \
@@ -65,6 +57,7 @@ if [[ -n "${BAZEL_OUTPUTS_DSYM:-}" ]]; then
     --archive \
     --delete \
     ${exclude_list:+--exclude-from="$exclude_list"} \
+    --perms \
     --chmod=u+w \
     --out-format="%n%L" \
     $(xargs -n1 <<< "$BAZEL_OUTPUTS_DSYM") \

xcodeproj/internal/bazel_integration_files/copy_outputs.sh

@@ -30,20 +30,14 @@ if [[ "$ACTION" != indexbuild ]]; then
       # rpaths to work
       ln -sfh "$PWD/$BAZEL_OUTPUTS_PRODUCT_BASENAME" "$TARGET_BUILD_DIR/$PRODUCT_NAME"
     else
-      if [[ "$(sw_vers -productVersion)" == "15.4.0" ]]; then
-        # 15.4.0's `rsync` has a bug that requires the src to have write
-        # permissions. We normally shouldn't do this as it modifies the bazel
-        # output base, so we limit this to only macOS 15.4.0.
-        chmod -R +w "$BAZEL_OUTPUTS_PRODUCT_BASENAME"
-      fi
-
       # Product is a bundle
       rsync \
         --copy-links \
         --recursive \
         --times \
         --delete \
         ${exclude_list:+--exclude-from="$exclude_list"} \
+        --perms \
         --chmod=u+w \
         --out-format="%n%L" \
         "$BAZEL_OUTPUTS_PRODUCT_BASENAME" \

xcodeproj/internal/templates/incremental_installer.sh

@@ -74,16 +74,10 @@ dest_dir="$(dirname "${dest}")"
 # Copy over `xcschemes`
 readonly dest_xcschemes="$dest/xcshareddata/xcschemes"
 
-if [[ "$(sw_vers -productVersion)" == "15.4.0" ]]; then
-  # 15.4.0's `rsync` has a bug that requires the src to have write permissions.
-  # We normally shouldn't do this as it modifies the bazel output base, so we
-  # limit this to only macOS 15.4.0.
-  chmod -R +w "$src_xcschemes"
-fi
-
 mkdir -p "$dest_xcschemes"
 rsync \
   --archive \
+  --perms \
   --chmod=u+w,F-x \
   --delete \
   "$src_xcschemes" "$dest_xcschemes/"

xcodeproj/internal/templates/legacy_installer.sh

@@ -136,17 +136,11 @@ fi
 
 # Sync over the project, changing the permissions to be writable
 
-if [[ "$(sw_vers -productVersion)" == "15.4.0" ]]; then
-  # 15.4.0's `rsync` has a bug that requires the src to have write permissions.
-  # We normally shouldn't do this as it modifies the bazel output base, so we
-  # limit this to only macOS 15.4.0.
-  chmod -R +w "$src"
-fi
-
 # Don't touch project.xcworkspace as that will make Xcode prompt
 rsync \
   --archive \
   --copy-links \
+  --perms \
   --chmod=u+w,F-x \
   --exclude=project.xcworkspace \
   --exclude=rules_xcodeproj/bazel \