Skip to content

Commit 9c117ee

Browse files
authored
Skip targets without "compiles" output group in compile_only aspect (#3172)
We are running some additional targets which are not Apple / Swift specific but still required and the build was failing since there was no "compiles" output group. I could add those rules to the list in the aspect definition. However I fear that it would set the bad example and the list would probably grow a lot over time. Signed-off-by: Adin Cebic <[email protected]>
1 parent c94afdf commit 9c117ee

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

xcodeproj/compile_only_aspect.bzl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,17 +66,13 @@ def _compile_only_aspect_impl(target, ctx):
6666
else:
6767
return []
6868

69-
for dep in deps:
70-
if OutputGroupInfo in dep and not hasattr(dep[OutputGroupInfo], "compiles"):
71-
fail(target, dep)
72-
7369
return [
7470
OutputGroupInfo(
7571
compiles = depset(
7672
transitive = outs + [
7773
dep[OutputGroupInfo].compiles
7874
for dep in deps
79-
if OutputGroupInfo in dep
75+
if OutputGroupInfo in dep and hasattr(dep[OutputGroupInfo], "compiles")
8076
],
8177
),
8278
),

0 commit comments

Comments
 (0)