Skip to content

Allow arbitrary generated folder location #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Allow arbitrary generated folder location #969

wants to merge 12 commits into from

Conversation

@keveleigh
Copy link
Contributor

Fixes #922

Ports over the "folder sentinel" pattern from MRTK2 (microsoft/MixedRealityToolkit-Unity#5603)

@keveleigh keveleigh self-assigned this Jan 9, 2025
@keveleigh keveleigh marked this pull request as ready for review January 9, 2025 22:21
@keveleigh keveleigh changed the base branch from feature/XRI3 to main January 9, 2025 22:28
@keveleigh keveleigh mentioned this pull request Jan 9, 2025
Open
@keveleigh keveleigh linked an issue Jan 10, 2025 that may be closed by this pull request
[FEATURE REQUEST] Allow moving the MRTK settings asset #922
Open
@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch from e405455 to f2abade Compare January 13, 2025 23:18
@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch 3 times, most recently from 712caee to ddee8ed Compare February 3, 2025 19:49
@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch from ddee8ed to 2759e4d Compare March 5, 2025 18:53
@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch from 266bec0 to 41fe18b Compare April 25, 2025 22:15
whitetigerhelix
whitetigerhelix previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@whitetigerhelix whitetigerhelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetOrCreateGeneratedFolderPath and AssetPostprocessor aren't run very often, right? What specifically causes this to be run? Assuming that is rare, this looks fine to me.

@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch from 41fe18b to a1cf3ae Compare May 28, 2025 19:23
@keveleigh keveleigh force-pushed the allow-arbitrary-generated-folder-location branch from a1cf3ae to 8a56914 Compare July 24, 2025 19:23
@keveleigh keveleigh enabled auto-merge (squash) July 28, 2025 20:19
@keveleigh
Copy link
Contributor Author

GetOrCreateGeneratedFolderPath and AssetPostprocessor aren't run very often, right? What specifically causes this to be run? Assuming that is rare, this looks fine to me.

@whitetigerhelix AssetPostprocessor runs every time the asset database is re-imported, which shouldn't be super frequent, but will happen as assets are added/removed/changed in a project. GetOrCreateGeneratedFolderPath also doesn't get called too frequently, but also shouldn't be doing much work, as the AssetPostprocessor should have cached the path already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whitetigerhelix whitetigerhelix whitetigerhelix left review comments

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft

@AMollis AMollis Awaiting requested review from AMollis

@shaynie shaynie Awaiting requested review from shaynie

At least 1 approving review is required to merge this pull request.

Assignees

@keveleigh keveleigh

Labels

Branch: main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow moving the MRTK settings asset

2 participants

@keveleigh @whitetigerhelix