[DON'T MERGE] Pickles Branching Factor 3 Experiment #16943
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
force-pushed
the
corvo/increase-pickles-branching-factor-destructive
branch
from
cd6efbc to
9193e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP destructive experiment to make Pickles support branching factor 3.
Some discoveries along the way
Composition_types.Branch_datauses a binary string representation to compressProofs_verifiedandDomain_log2together. The former is fixed to 2 bits. This PR make the former to be 3 bits. We should actually use a net-string-like format, so arbitrary branches could be de-serialized from binaries without more information.