Skip to content

Fix flakiness of client_sdk unit tests #11605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fix flakiness of client_sdk unit tests #11605

merged 2 commits into from
Aug 3, 2022

Conversation

mitschabaude
Copy link
Contributor

@mitschabaude mitschabaude commented Aug 2, 2022 •
edited
Loading

@mitschabaude mitschabaude added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Aug 2, 2022
balsoft
balsoft approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@balsoft balsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built 10 times without failure on my machine via Nix (after merging with mrmr1993/merge-back-to-develop).

@mrmr1993 mrmr1993 merged commit 35b1702 into develop Aug 3, 2022
@mrmr1993 mrmr1993 deleted the fix/client-sdk-test-flakiness branch August 3, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@balsoft balsoft balsoft approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client_sdk: Error: Cannot find module 'env'
3 participants
@mitschabaude @mrmr1993 @balsoft