Replace deprecated functions and values #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the same effect as giving the <raise>yes</raise> option to next/prevwindow but makes it optional and keybindable, so if W-Tab is nextwindow, you can have W-q as raisetemp.
…eful while alt-tabbing).
Previously if you click-drag-released the left button on the root window to a client window, Openbox would ignore the release because we don't own the client window. Now check if we are in a button press or not before ignoring it. The bug was we would initiate a move when the cursor was moved over a titlebar even when the button was unpressed because the variable didn't get cleared properly. This fix is very ugly.
Add option to change the client list menus back to separating iconified windows with a line instead of bracketing them.
If you somehow still need this, I think you can just add dcop ksplash "upAndRunning(Qstring)" "wm started" to your autostart file or otherwise.
Useful for example for ALT-F4 and such bindings, where you don't want to accidentally close every window on your desktop. Requires XKB extension.
Ie, pixel size instead of point size. (I think).
This makes it a lot easier to move fullscreen windows between monitors with the Resize action.
This will surely cause bugreports once 8K screens are common.
This time remembering that screen_num_monitors can change.
This caused gcc to assume the user never specifies a desktop by number, which was not very helpful. Please crash when reaching an assert, thanks.
The calls to client_calc_layer_internal can modify stacking_list, which can cause us to follow dangling ->next pointers (either by the pointer itself already being freed, or it pointing to a freed area). Avoid this by copying the list first, the goal is to visit every client in the list once so this should be fine.
Mikachu
force-pushed
the
work
branch
2 times, most recently
from
d2e76a6 to
fd31d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes change the many deprecated functions and values to non-deprecated ones.
I have also tested these changes by using them since april 2024 on debian versions 12.5 to 12.9 and did not experience any problems.