Skip to content

Feat: Add Support for schemars #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cappuccinocosmico
Copy link

Hey, I needed schemars support for some API documentation, and thought I should throw this back. Its totally optional if you dont want to merge it.

@MidasLamb
Copy link
Owner

Since, according to your commits, there seems to be a split in which version is used, I think it's a good idea to call the features according to the version, so for supporting of 0.9, the feature flag is schemars09 and for schemars 1.0 it would be schemars1. That way if new releases are cut of schemars, we can add support for it without breaking the version for older versions.

@cappuccinocosmico
Copy link
Author

Awesome, I think that's a great way to handle it and just made the changes. My apologies for the delay, my GitHub notifications were turned off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants