Skip to content

Conversation

DJm00n
Copy link
Contributor

@DJm00n DJm00n commented Jun 25, 2025

Format legacy *_CHARSET constant tables.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

@DJm00n : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

DJm00n added 10 commits June 25, 2025 15:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@stevewhims
Copy link
Member

Thanks, @DJm00n, I like the idea in general of changing HTML to markdown!

But why are we making this particular change? Note that we're losing value by removing headings such as "Korean Windows". Is the expectation that readers will already know that JOHAB_CHARSET == Korean? Or if not, they can go look it up? Seems dubious.

In any case, for a constant such as JOHAB_CHARSET, I'd put that in bold (asterisk asterisk), and not backticks. Backticks are for code, filenames, that kind of thing.

Also, parameter names should be in italics (as they were before this change), not backticks (as they are after this change). But again changing HTML to markdown italics is desirable.

So I won't take this PR right now.

Thanks! :)
-Steve

DJm00n added 11 commits July 31, 2025 01:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
DJm00n added 23 commits July 31, 2025 01:23

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@DJm00n
Copy link
Contributor Author

DJm00n commented Jul 30, 2025

@stevewhims fixed formatting as you're asked.

Note that we're losing value by removing headings such as "Korean Windows". Is the expectation that readers will already know that JOHAB_CHARSET == Korean? Or if not, they can go look it up? Seems dubious.

I removed headings such as "Korean Windows" because any Windows version since NT have these defines. These are legacy font codepages that are there for backwards compatibility.

Actual table was borrowed here: https://github.com/MicrosoftDocs/windows-driver-docs-ddi/blame/staging/wdk-ddi-src/content/prntfont/ns-prntfont-_printifi32.md#L109-L129

Ref: https://github.com/wine-mirror/wine/blob/master/dlls/win32u/font.c#L291-L311

@stevewhims stevewhims merged commit 0c868cc into MicrosoftDocs:docs Jul 31, 2025
1 check passed
@DJm00n DJm00n deleted the patch-16 branch August 1, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants