WlxLoggedOutSAS: Tell how the pProfile structure is allocated. #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like the pNprNotifyInfo fields, the fields inside the returned pProfile structure, and the structure itself, appears to be allocated with `LocalAlloc()`. My investigations appear to show that this is what Windows <= 2003 msgina.dll does, and what winlogon.exe expects (since the latter will free the buffers with `LocalFree()`).
|
@HBelusca : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Note for reviewers: it would be advisable that someone from the Windows Security/Login team (and having access to the legacy msgina and winlogon sources) check this PR, as well as the related ones: #2035, #2036, and #2037, verifying the claims I made (obtained by an independent investigation), before approving any of these PRs. |
alvinashcraft
requested review from
alvinashcraft
and removed request for
GrantMeStrength
Update paths to avoid redirected URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My investigations appear to show that, on Windows <= 2003 (what msgina.dll does), similar to the
pNprNotifyInfofields, the fields inside the returnedpProfilestructure, and the structure itself, are allocated withLocalAlloc().winlogon.exe expects this, since it will free these buffers with
LocalFree().