Skip to content

Update addCustomView.md #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ericregnier
Copy link
Contributor

Corrected the notes about invalid GUIDs

Corrected the notes about invalid GUIDs
@Nkrb Nkrb added the needs-writer-review Requires the writer to review label Aug 25, 2020
@KumarVivek KumarVivek added the waiting-on-internal-feedback Topic owner is waiting on internal teams to respond before taking any action on the feedback label Oct 8, 2020
@JimDaly JimDaly self-requested a review as a code owner March 28, 2022 16:17
@JimDaly JimDaly assigned JimDaly and unassigned Nkrb Mar 28, 2022
@JimDaly JimDaly added do-not-merge and removed assigned-to-author waiting-on-internal-feedback Topic owner is waiting on internal teams to respond before taking any action on the feedback assigned-to-contributors labels Mar 28, 2022
@JimDaly
Copy link
Contributor

JimDaly commented Mar 28, 2022

Since the change directly changes the meaning of the current description. Need feature team to approve.

@JimDaly
Copy link
Contributor

JimDaly commented Mar 28, 2022

@adrianorth Can you approve this change?

@JimDaly JimDaly assigned miglisic and chmoncay and unassigned adrianorth Mar 28, 2022
@JimDaly
Copy link
Contributor

JimDaly commented Mar 28, 2022

@miglisic & @chmoncay

Change to addCustomView (Client API reference) directly contradicts current documentation saying it doesn't work.

Current:

This value is never saved and only needs to be unique among the other available views for the lookup. A string for a non-valid GUID will work, for example “00000000-0000-0000-0000-000000000001”. It’s recommended that you use a tool like guidgen.exe to generate a valid GUID.

Proposed:

This value is never saved and only needs to be unique among the other available views for the lookup on the current form. A string for a non-valid GUID will not work, for example “00000000-0000-0000-0000-000000000001” will not work. It’s recommended that you use a tool like guidgen.exe to generate a valid GUID.

@opbld32
Copy link

opbld32 commented Sep 12, 2022

Docs Build status updates of commit cca03bf:

✅ Validation status: passed

File Status Preview URL Details
powerapps-docs/developer/model-driven-apps/clientapi/reference/controls/addCustomView.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@phecke phecke removed their request for review January 20, 2023 23:24
@MicrosoftDocs MicrosoftDocs locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge needs-writer-review Requires the writer to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants