-
Notifications
You must be signed in to change notification settings - Fork 967
Update cchecklistbox-class.md #5426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Slightly change instructions so they better match the code example: tell programmer to instantiate `CCheckListBox` instead of deriving a new class from it.
@edwinvp : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 3ffe547: ✅ Validation status: passed
For more details, please refer to the build report. |
Tell that the check list box needs to be subclassed too
Learn Build status updates of commit 50fbf12: ✅ Validation status: passed
For more details, please refer to the build report. |
@TylerMSFT - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this statement need to be updated as well? (line 47)
To create your own checklist box, you must derive your own class from CCheckListBox
. To derive your own class, write a constructor for the derived class, then call Create
.
Update another spot in the document where it suggests deriving a class for your own checklist box. Also mention how to work around artifacts that show for some versions of the framework.
Learn Build status updates of commit ee2fed1: ✅ Validation status: passed
For more details, please refer to the build report. |
Thank you, you are right, I have missed this. I have re-edited the file in the hopes the changes will be useful to somebody. |
@microsoft-github-policy-service agree |
@TylerMSFT Would you add a comment to indicate what action to take on this PR? |
Collapse multi-line md that would be rendered as one line
Learn Build status updates of commit e9fbe26: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to clean up the wording and preserve the original meaning. Only the wording is reviewed, I didn't verify the contents.
Co-authored-by: Rageking8 <[email protected]>
Co-authored-by: Rageking8 <[email protected]>
Learn Build status updates of commit fb35a2e: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 433a37b: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 088f162: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the time to verify the addition to the topic.
Could either you (RageKing8) review them or remove them?
They seem to be right in spirit, but I'd like to verify first.
Slightly change instructions so they better match the code example: tell programmer to instantiate
CCheckListBox
instead of deriving a new class from it.