Skip to content

Update cchecklistbox-class.md #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

edwinvp
Copy link

@edwinvp edwinvp commented Jun 16, 2025

Slightly change instructions so they better match the code example: tell programmer to instantiate CCheckListBox instead of deriving a new class from it.

Slightly change instructions so they better match the code example: tell programmer to instantiate `CCheckListBox` instead of deriving a new class from it.
Copy link
Contributor

@edwinvp : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 3ffe547:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

Tell that the check list box needs to be subclassed too
Copy link
Contributor

Learn Build status updates of commit 50fbf12:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@TylerMSFT - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 16, 2025
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this statement need to be updated as well? (line 47)

To create your own checklist box, you must derive your own class from CCheckListBox. To derive your own class, write a constructor for the derived class, then call Create.

Update another spot in the document where it suggests deriving a class for your own checklist box.

Also mention how to work around artifacts that show for some versions of the framework.
Copy link
Contributor

Learn Build status updates of commit ee2fed1:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

@edwinvp
Copy link
Author

edwinvp commented Jun 18, 2025

Wouldn't this statement need to be updated as well? (line 47)

Thank you, you are right, I have missed this. I have re-edited the file in the hopes the changes will be useful to somebody.

@edwinvp
Copy link
Author

edwinvp commented Jun 18, 2025

@microsoft-github-policy-service agree

@v-dirichards
Copy link
Contributor

Wouldn't this statement need to be updated as well? (line 47)

Thank you, you are right, I have missed this. I have re-edited the file in the hopes the changes will be useful to somebody.

@TylerMSFT Would you add a comment to indicate what action to take on this PR?

Collapse multi-line md that would be rendered as one line
@edwinvp edwinvp requested review from TylerMSFT and Rageking8 June 18, 2025 16:26
Copy link
Contributor

Learn Build status updates of commit e9fbe26:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

@Rageking8 Rageking8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to clean up the wording and preserve the original meaning. Only the wording is reviewed, I didn't verify the contents.

@edwinvp edwinvp requested a review from Rageking8 June 18, 2025 19:51
Copy link
Contributor

Learn Build status updates of commit fb35a2e:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

Learn Build status updates of commit 433a37b:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

Learn Build status updates of commit 088f162:

✅ Validation status: passed

File Status Preview URL Details
docs/mfc/reference/cchecklistbox-class.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the time to verify the addition to the topic.
Could either you (RageKing8) review them or remove them?
They seem to be right in spirit, but I'd like to verify first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants