(AzureCXP) fixed continueAsNew for JavaScript

[ChaitanyaNaykodi-MSFT]

resolves MicrosoftDocs/azure-docs#70981

[PRMerger19]

@ChaitanyaNaykodi-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

[cgillum]

@davidmrdavid is this fix correct? I thought we didn't need to yield continueAsNew(), but maybe the JavaScript SDK is doing something I didn't expect?

[ktoliver]

Note that publishing in this repository is suspended until Tuesday, March 2. Merging will resume Tuesday. Authors can still review and sign off on PRs during this time. Thanks.

[davidmrdavid]

This is right, @cgillum.
In Python, where I contributed to continue_as_new, we handle both the case where the API is yield'ed and the case where it is simply called. In both cases, it works as expected.

We needed to handle both cases because JS already had the precedent of requiring a yield for continueAsNew, which departs from the C# style. In other words, it had the requirement implied by this PR.

I believe that behavior in JS was unintended, and that we wanted to fix it to support both cases, like Python, but that we never followed-up on that. That's the tricky thing with OOProc, bugs need to be followed-up across repos....

That aside, I believe we should merge this fix and simply create a ticket to ensure we finally fix continueAsNew in JS to be like in Python. Once we complete that item, we can tweak the docs once more.

[davidmrdavid]

I created the JS item here: Azure/azure-functions-durable-js#248

[cgillum]

Thanks @davidmrdavid for the confirmation. In that case, I think we're good to merge this PR.

[ChaitanyaNaykodi-MSFT]

Thank you @cgillum & @davidmrdavid

[ChaitanyaNaykodi-MSFT]

#sign-off

[PRMerger15]

@ChaitanyaNaykodi-MSFT: I'm sorry - only the author of this article, @cgillum, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

[davidmrdavid]

#sign-off

[PRMerger20]

@davidmrdavid: I'm sorry - only the author of this article, @cgillum, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

[davidmrdavid]

@cgillum, do you mind doing the sign-off?

[cgillum]

#sign-off

[ktoliver]

@cgillum Thanks for the sign-off. We'll merge this approved pull request on Tuesday when publishing in this repo resumes.