tc6: align all declaration and definition parameter names#77
Open
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Open
tc6: align all declaration and definition parameter names#77tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Conversation
… branch) Rename parameters in declarations to match implementations: - tc6-regs.h: pInst -> pTC6 (TC6Regs_Reinit, TC6Regs_GetChipRevision) - tc6.h: pInst -> g for public functions (TC6_EnableData, TC6_GetRawSegments, TC6_MultipleRegisterAccess, TC6_UnlockExtendedStatus, TC6_Destroy, TC6_Reset, TC6_GetState, TC6_GetInstance) - tc6.h: event -> error (TC6_GetErrorStr) - tc6.c: buff/size_of_buff -> tx_buf/tx_buf_size (mk_ctrl_req, mk_secure_ctrl_req) Updated documentation comments to match new parameter names. All changes are declaration-only; implementation behavior unchanged. Finding: clang-tidy/readability-inconsistent-declaration-parameter-name at tc6-regs.h:116,131 tc6.h:153,173,234,241,258,263,271,277,283 tc6.c:202,211,212
tkummermehr
force-pushed
the
static-analysis/param-naming-async
branch
from
82a3726 to
e707a65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename 14 parameters in declarations to match implementations: