tc6: merge consecutive identical switch cases#76
Open
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Open
tc6: merge consecutive identical switch cases#76tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Conversation
REGISTER_OP_READ and REGISTER_OP_READWRITE_STAGE1 both set write = false. Merge into a single case with fall-through to reduce duplication. Finding: clang-tidy/bugprone-branch-clone at libtc6/src/tc6.c:832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge REGISTER_OP_READ and REGISTER_OP_READWRITE_STAGE1 cases which both set write = false. Reduces code duplication in switch statement. Fixes clang-tidy bugprone-branch-clone warning.
Test plan