tc6: fix implicit widening of multiplication in pointer offsets#74
Open
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Open
tc6: fix implicit widening of multiplication in pointer offsets#74tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Conversation
Explicit cast of num_regs (uint8_t) to size_t before multiplication prevents implicit widening of the intermediate unsigned int product. Finding: clang-tidy/bugprone-implicit-widening-of-multiplication-result at libtc6/src/tc6.c:1053,1094
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cast num_regs (uint8_t) to size_t before multiplication to avoid implicit widening of the intermediate product. Fixes 2 clang-tidy bugprone-implicit-widening-of-multiplication-result warnings.
Test plan