Fix magic comparison in TC6LwIP_Service#70
Open
tkummermehr wants to merge 18 commits intomainfrom
Open
Conversation
TC6Regs_CheckTimers iterates all TC6_MAX_INSTANCES entries of m_reg[] and calls DoInitialization on each. Slots that no caller has yet bound via TC6Regs_Init still have pReg->pTC6 == NULL, so the existing !pReg->initialized guard lets the init sequence run against a NULL MAC-PHY handle, dereferencing NULL in TC6_Reset / TC6_WriteRegister on every tick until a real Init arrives. Masked at the default TC6_MAX_INSTANCES == 1, triggers as soon as a project configures more. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…sync branch) (#61) Co-authored-by: Sven Semmler <Sven@SvenSemmler.org>
…ync branch) (#59) Co-authored-by: Sven Semmler <Sven@SvenSemmler.org>
Change condition from LWIP_TC6_MAGIC != lw->magic to LWIP_TC6_MAGIC == lw->magic to correctly check initialized instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the magic field check logic in TC6LwIP_Service from inequality to equality comparison.