fix(StorageESP): shader mode not rendering - #6571
Merged
Merged
Conversation
The 26.2 update removed the BlockEntityRenderer submission from SimpleBlockRenderer.renderWithBlockEntity(), which was the only path drawing geometry for blocks whose visuals come entirely from their block entity renderer (chests, trapped chests, ender chests, shulker boxes, decorated pots). Their block state models have no quads, so nothing was rendered in Shader mode while tracers kept working. Restore the block entity rendering with the 26.2 node-collector API (SubmitNodeStorage/SubmitNodeCollection): intercept submitModel and write the model vertices straight into the Storage ESP mesh, calling model.setupAnim() to keep the lid/open animations working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The 26.2 update removed the BlockEntityRenderer submission from SimpleBlockRenderer.renderWithBlockEntity(), which was the only path drawing geometry for blocks whose visuals come entirely from their block entity renderer (chests, trapped chests, ender chests, shulker boxes, decorated pots). Their block state models have no quads, so nothing was rendered in Shader mode while tracers kept working.
Restore the block entity rendering with the 26.2 node-collector API (SubmitNodeStorage/SubmitNodeCollection): intercept submitModel and write the model vertices straight into the Storage ESP mesh, calling model.setupAnim() to keep the lid/open animations working.
Related issues
closes #6567
How Has This Been Tested?
screenshot will be added later
Checklist: