Avoid mojang API ratelimit exception spamming on startup when refresh… #5409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RacoonDog
suggested changes
May 17, 2025
There was a problem hiding this comment.
Friends.get().iterator() returns an ArrayList iterator, which would throw a ConcurrentModificationException if any friends are added/removed during the refresh
also opening the friends tab during the initial refresh would cause all of the remaining friends to be refreshed twice (and faster), so there's still rate-limit issues there
edit: considering the player head texture api endpoint is used in a few different areas in meteor, i think it'd just be better to make a dedicated rate limited queue for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing friends
Type of change
Description
Meteor does not handle rate limits when refreshing Friends list. This results in the friends list never getting updated and a lot of spam in logs at startup.
1 second delay should do the trick.
Related issues
Mention any issues that this pr relates to.
How Has This Been Tested?
Videos or screenshots of the changes if applicable.
Checklist: